EricJoy2048 commented on code in PR #6050:
URL: https://github.com/apache/seatunnel/pull/6050#discussion_r1435938203
##########
seatunnel-engine/seatunnel-engine-client/src/main/java/org/apache/seatunnel/engine/client/job/ClientJobProxy.java:
##########
@@ -117,10 +115,6 @@ public JobResult waitForJobCompleteV2() {
throw new RuntimeException(e);
}
LOGGER.info(String.format("Job (%s) end with state %s", jobId,
jobResult.getStatus()));
- if (StringUtils.isNotEmpty(jobResult.getError())
- || jobResult.getStatus().equals(JobStatus.FAILED)) {
- throw new SeaTunnelEngineException(jobResult.getError());
- }
Review Comment:
> If client never throw exception even job failed. The shell status code
always return 0, does not meet shell standards. Also client side will not get
job result error msg. We need test case to cover it.
Done, I have added test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
