Hisoka-X commented on code in PR #6065:
URL: https://github.com/apache/seatunnel/pull/6065#discussion_r1435913816
##########
seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/JsonDeserializationSchema.java:
##########
@@ -132,11 +133,11 @@ private SeaTunnelRow convertJsonNode(JsonNode jsonNode) {
}
try {
return (SeaTunnelRow) runtimeConverter.convert(jsonNode);
- } catch (Throwable t) {
+ } catch (RuntimeException e) {
Review Comment:
I prefer change `Throwable` to `Exception` of all catch condition. Change to
`RuntimeException` would lose some exception like `NullPointerException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
