EricJoy2048 commented on code in PR #4470:
URL:
https://github.com/apache/incubator-seatunnel/pull/4470#discussion_r1165029300
##########
seatunnel-connectors-v2/connector-jdbc/pom.xml:
##########
@@ -122,6 +123,12 @@
<version>${saphana.version}</version>
<scope>provided</scope>
</dependency>
+
+ <dependency>
+ <groupId>net.snowflake</groupId>
+ <artifactId>snowflake-jdbc</artifactId>
+ <version>${snowflake.version}</version>
Review Comment:
Please make scope is `provided`.
And please add this dependency in `seatunnel-dist/pom.xml` like other jdbc
drivers.
##########
docs/en/connector-v2/source/Snowflake.md:
##########
@@ -0,0 +1,53 @@
+# Snowflake
+
+> Snowflake source connector
+>
+> ## Description
+>
+> Read Snowflake data through [Jdbc connector](Jdbc.md).
+> Support Batch mode and Streaming mode. The tested Snowflake version is 3.xx
+
+## Options
Review Comment:
Same as above.
##########
docs/en/connector-v2/sink/Snowflake.md:
##########
@@ -0,0 +1,57 @@
+# Snowflake
+
+> Snowflake sink connector
+>
+> ## Description
+>
+> Write Snowflake data through [Jdbc connector](Jdbc.md).
+> Support Batch mode and Streaming mode. The tested Snowflake version is 3.xx
+> On the underlying implementation, through the jdbc driver of Snowflake,
execute the upsert statement to write data to HBase.
+> Two ways of connecting Snowflake with Java JDBC. One is to connect to
zookeeper through JDBC, and the other is to connect to queryserver through JDBC
thin client.
+
+## Options
Review Comment:
Need a options table like this:
https://seatunnel.apache.org/docs/2.3.1/connector-v2/sink/S3File#options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
