Hisoka-X commented on code in PR #4161:
URL:
https://github.com/apache/incubator-seatunnel/pull/4161#discussion_r1138298176
##########
seatunnel-core/seatunnel-starter/src/main/bin/seatunnel-cluster.sh:
##########
@@ -69,7 +70,8 @@ do
if [[ "${i}" == *"JvmOption"* ]]; then
JVM_OPTION="${i}"
JAVA_OPTS="${JAVA_OPTS} ${JVM_OPTION#*=}"
- break
+ elif [[ "${i}" == "-d" ]]; then
Review Comment:
Please make sure if user use `-h` or `--help`, the help msg must print on
the console. At now if user use `./bin/seatunnel-cluster.sh -h -d`, the console
will not print anything. By the way, user use `-h` can't know how to use daemon
mode (please add it into `CommandArgs`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
