[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3028: [Improve][E2E] Improve testcase output log style

[GitBox]

hailin0 commented on code in PR #3028:
URL: 
https://github.com/apache/incubator-seatunnel/pull/3028#discussion_r990656928


##########
seatunnel-e2e/seatunnel-flink-connector-v2-e2e/connector-mongodb-flink-e2e/src/test/java/org/apache/seatunnel/e2e/flink/v2/mongodb/MongodbIT.java:
##########
@@ -90,7 +91,7 @@ public void startMongoContainer() {
                 .forPort(MONGODB_PORT)
                 .forStatusCodeMatching(response -> response == HTTP_OK || 
response == HTTP_UNAUTHORIZED)
                 .withStartupTimeout(Duration.ofMinutes(2)))
-            .withLogConsumer(new Slf4jLogConsumer(log));
+            .withLogConsumer(new 
Slf4jLogConsumer(DockerLoggerFactory.getLogger(MONGODB_IMAGE)));

Review Comment:
   log example:
   
   <img width="1700" alt="image" 
src="https://user-images.githubusercontent.com/14371345/194716032-c3f0e8f0-75e0-46a3-892a-6dbd85590be1.png";>
   



##########
seatunnel-e2e/seatunnel-e2e-common/src/test/java/org/apache/seatunnel/e2e/common/container/AbstractTestContainer.java:
##########
@@ -102,8 +102,18 @@ protected Container.ExecResult 
executeCommand(GenericContainer<?> container, Str
         command.addAll(getExtraStartShellCommands());
 
         Container.ExecResult execResult = container.execInContainer("bash", 
"-c", String.join(" ", command));
-        LOG.info(execResult.getStdout());
-        LOG.error(execResult.getStderr());
+        if (execResult.getStdout() != null && execResult.getStdout().length() 
> 0) {
+            LOG.info("\n==================== ExecuteConfigFile: {} STDOUT 
start ====================\n"
+                    + "{}"
+                    + "\n==================== ExecuteConfigFile: {} STDOUT end 
  ====================",
+                configPath, execResult.getStdout(), configPath);
+        }
+        if (execResult.getStderr() != null && execResult.getStderr().length() 
> 0) {
+            LOG.error("\n==================== ExecuteConfigFile: {} STDERR 
start ====================\n"
+                    + "{}"
+                    + "\n==================== ExecuteConfigFile: {} STDERR end 
  ====================",
+                configPath, execResult.getStderr(), configPath);
+        }

Review Comment:
   log example
   
   <img width="1700" alt="image" 
src="https://user-images.githubusercontent.com/14371345/194716194-004ea545-a242-4ac5-9e3c-4c91c6e163af.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org