CalvinKirs commented on a change in pull request #1475:
URL:
https://github.com/apache/incubator-seatunnel/pull/1475#discussion_r825683035
##########
File path:
seatunnel-core/seatunnel-core-base/src/main/java/org/apache/seatunnel/config/ConfigBuilder.java
##########
@@ -102,6 +103,22 @@ private boolean checkIsStreaming() {
return
sourceConfigList.get(0).getString(PLUGIN_NAME_KEY).toLowerCase().endsWith("stream");
}
+ private boolean checkIsContainHive() {
+ List<? extends Config> sourceConfigList =
config.getConfigList(PluginType.SOURCE.getType());
+ for (Config c : sourceConfigList) {
+ if (c.getString(PLUGIN_NAME_KEY).toLowerCase().contains("hive")) {
+ return true;
+ }
+ }
+ List<? extends Config> sinkConfigList =
config.getConfigList(PluginType.SINK.getType());
+ for (Config c : sinkConfigList) {
+ if (c.getString(PLUGIN_NAME_KEY).toLowerCase().contains("hive")) {
+ return true;
+ }
+ }
+ return false;
+ }
+
Review comment:
Overall LGTM, just leave a question, is it appropriate to put this kind
of business-related here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
