BenJFan commented on a change in pull request #1410:
URL:
https://github.com/apache/incubator-seatunnel/pull/1410#discussion_r822360764
##########
File path:
seatunnel-connectors/seatunnel-connector-spark-jdbc/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc2/DefaultSource.scala
##########
@@ -102,6 +102,6 @@ class DefaultSource extends CreatableRelationProvider with
RelationProvider
conn.close()
}
- createRelation(sqlContext, parameters)
+ JDBCRelation(Array.empty, new
JDBCOptions(parameters))(sqlContext.sparkSession)
}
Review comment:
> @zhaomin1423 I think it's better to keep it as it is, because this
piece is not the cause of the error, I'd like to hear what other people think
Change the code, but leave a comment which tell other why do like that.
Maybe this way is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
