asdf2014 commented on a change in pull request #906:
URL:
https://github.com/apache/incubator-seatunnel/pull/906#discussion_r777918011
##########
File path:
seatunnel-config/src/main/java/com/typesafe/config/impl/ConfigParser.java
##########
@@ -125,13 +125,13 @@ private AbstractConfigValue
parseValue(AbstractConfigNodeValue n, List<String> c
Path path = pathStack.peekFirst();
if (path != null
- && ("input".equals(path.first())
- || "filter".equals(path.first())
- || "output".equals(path.first())
- || "source".equals(path.first())
- || "transform".equals(path.first())
- || "sink".equals(path.first()))) {
- v = parseObjectForSeatunnel((ConfigNodeObject) n);
+ && (path.first().equals("input")
Review comment:
Maybe we should rollback these lines, because the original way is
better, which can avoid NPE, right
##########
File path: seatunnel-config/pom.xml
##########
@@ -35,6 +35,96 @@
<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<skip.pmd.check>true</skip.pmd.check>
+
<seatunnel.shade.package>org.apache.seatunnel.shade</seatunnel.shade.package>
</properties>
+ <dependencies>
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ </dependency>
+
+ <dependency>
+ <groupId>com.typesafe</groupId>
+ <artifactId>config</artifactId>
+ </dependency>
+ </dependencies>
+
+ <build>
+
+ <finalName>${project.artifactId}-${project.version}</finalName>
+
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <version>3.2.4</version>
Review comment:
Maybe we should use `${maven-shade-plugin.version}` instead, which is
`2.4.3`, or just delete this line, and it will be the same as the version in
`pluginManagement` in parent module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
