leizhiyuan commented on PR #1433: URL: https://github.com/apache/rocketmq-clients/pull/1433#issuecomment-6381201323
Rebased onto `master` again (`222e0784`, after #1427). As planned in #1412 (¶), `check_started` comes first: in `receive_internal` before #1427's argument checks, and in `change_invisible_duration` before the duration conversion. #1427 already added `OPERATION_CHANGE_INVISIBLE_DURATION`, so this PR no longer adds it. #1427's no-RPC test helper now expects `check_started`. `50f573af` → `17dcac14`. `cargo test -- --test-threads=1`: 144 passed (lib), stable over repeated runs; integration and doc tests pass; `fmt --check`, `doc` and `build --examples --all-features` are clean; `clippy -D warnings` is clean; `clippy --all-targets` shows the same 2 extra `await_holding_lock` warnings from the `MTX` guard in the new tests as before. This PR still conflicts with #1431 in `simple_consumer.rs` (both edit `change_invisible_duration` and append tests). I checked the resolution on a temporary merge of the two branches: `check_started`, then #1427's conversion, then #1431's handle write-back, keeping all tests; 146 passed. Whichever lands second, I will rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
