Felix-Gong opened a new pull request, #11469: URL: https://github.com/apache/rocketmq/pull/11469
Fixes #11468 `buildAdminMessage` kept only the first non-empty entry of the repeated `system_properties.keys` field (`setKeys` + `break`), so an `AdminSendMessage` carrying several index keys stored just one of them and still answered OK. The data plane keeps the whole list — `SendMessageActivity` hands `system_properties.keys` to `Message.setKeys(Collection)`, which joins it. The change collects every non-empty key and passes the list to `setKeys`, matching the data plane. Precedence with the singular `key` field is untouched: a non-empty `system_properties.keys` still overrides it, and an all-empty list leaves the singular key in place. Test: `adminSendMessageKeepsAllSystemPropertyKeysTest` sends `["key1", "", "key2", "key3"]` and asserts the stored message carries `key1 key2 key3`. It fails with `key1` vs `key1 key2 key3` on the unpatched service (checked both ways). Full `proxy` module: 454 tests green on JDK 11. Coordination: PR #11357 touches `selectQueue` in the same class for #11356; this change is confined to `buildAdminMessage` and its key handling, so the two do not overlap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
