X-LightYear opened a new pull request, #7225: URL: https://github.com/apache/rocketmq-dashboard/pull/7225
## Summary - route `rmq.user.list` through the existing bounded ACL user page service - add optional literal keyword and page controls with page metadata - allow legal global ACL users whose cluster bindings are absent ## Root cause `UserListToolHandler` used `AclService.listUsers`, which returns the complete ACL user inventory without pagination, even though the REST contract already exposes `AclService.pageUsers`. The catalog also required `clusters` to be a non-null array although `AclUserItem` preserves null for global users. ## Fix Use a dedicated `UserListInput` with optional keyword/page fields and return `PageOutput<AclUserItem>` from `pageUsers`. Update the catalog and output contract coverage accordingly. ## Testing - `UserListToolHandlerTest`: deterministic bounded-page forwarding and global-user schema coverage - `AclServiceTest`, `AclControllerTest`, `ToolCatalogTest`, `ToolOutputSchemaContractTest`: 129 passed - MCP discovery/execution/binding/routing/registration tests: 30 passed - checkstyle: 0 violations - package compile/repackage passed; the existing Windows environment lacks `python3` for the repository binary-license gate (exit 9009) Fixes #7224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
