dxz0069 commented on PR #6687: URL: https://github.com/apache/rocketmq-dashboard/pull/6687#issuecomment-6265636370
Rebased onto the current head (c34535d) and narrowed per the 2026-10-16 convention that keeps the consumer table's sorters — trunk evolved `onlineInstancesCount` for exactly that display/sort agreement, so fighting it would be wrong. This PR now removes the page-local sorters from the **audit, alerts and topic** tables only (17 declarations); the consumer sorters, both helpers and all their tests stay as trunk has them, which also resolves the earlier question about the caller-less helpers (they have callers again). ``` cd web npx vitest run --maxWorkers=1 src/pages/ops/__tests__/AuditPage.test.tsx src/pages/ops/__tests__/AlertsPage.test.tsx src/pages/instance/__tests__/TopicPage.test.tsx src/pages/instance/__tests__/ConsumerPage.test.tsx Tests 162 passed (162) ``` Still happy to drop or keep the audit/alerts halves per your merge-order ruling — #6686's render changes and this branch line up on the audit table either way now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
