lizhimins commented on PR #6886: URL: https://github.com/apache/rocketmq-dashboard/pull/6886#issuecomment-6265568736
Same fix as this one, and we took #6876: it parameterises all five window aggregations and covers the empty-window, disabled-window and unavailable-sample edges (147 lines of tests against 35 here), on the same base. Worth porting into a follow-up if you want to: your pure `aggregate(rule, sample, window)` function signature is a nicer test seam than the helper in #6876, which reaches into the repository directly. Closing as superseded — thanks for the overlap, and sorry for the duplicated effort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
