Loyal-Young opened a new pull request, #6914: URL: https://github.com/apache/rocketmq-dashboard/pull/6914
### Which issue(s) this PR fixes Fixes #5992. The earlier #5993 was closed by the stale workflow without merging; the issue remains on the current base branch. ### Problem The ACL rule dialog built its principal choices from the current page of the Users table. On a multi-page user inventory, or after filtering that table, an existing user outside the loaded page could not be selected for a new rule. The rule table also missed that user's admin badge. ### Change - Load the instance's full user directory through the existing `listAclUsers` endpoint for principal choices and admin badges, while keeping the Users table server-paginated. - Key the directory response by instance and refresh generation so a late response from another instance cannot populate the current picker. Refresh after user mutations; retain the current page as a fallback while the directory is unavailable. - Keep the principal of an edited rule selectable even if that user is absent from the directory response. - Add a regression with a principal that is in the directory but outside the loaded user page. It failed on the old code and passes with the change. ### Verification - `cd web && vitest run src/pages/instance/__tests__/AclPage.test.tsx` — 30 passed. - `cd web && tsc --noEmit` — passed. - ESLint on both changed files — passed. - `git diff --check` — passed. ### AI use I used AI assistance to trace the paged table and rule picker state, draft the regression and patch, and review the test output. I verified the final change with the commands above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
