Loyal-Young opened a new pull request, #6913:
URL: https://github.com/apache/rocketmq-dashboard/pull/6913

   ### Which issue(s) this PR fixes
   
   Fixes #5996. The earlier #5997 was closed by the stale workflow without 
merging; the issue and the eleven sorters remain on the current base branch.
   
   ### Problem
   
   The ACL rule and user inventories fetch one server page at a time, but 
eleven Ant Design column sorters reorder only the rows on that page. A sorted 
header therefore implies an order across the whole result set that the API does 
not provide.
   
   ### Change
   
   Remove the page-local sorters from both paginated tables. The server 
endpoints do not accept a sort key, so this removes misleading controls without 
changing the server page order. Add a test that checks both visible ACL tables 
for sortable headers; it failed with eleven headers before the fix and passes 
afterward.
   
   ### Verification
   
   - `cd web && vitest run src/pages/instance/__tests__/AclPage.test.tsx` — 30 
passed.
   - `cd web && tsc --noEmit` — passed.
   - ESLint on both changed files — passed.
   - `git diff --check` — passed.
   
   ### AI use
   
   I used AI assistance to trace the table pagination and sort behavior, draft 
the focused change and regression, and review the test output. I verified the 
result with the commands above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to