The GitHub Actions job "CI" on 
rocketmq-dashboard.git/codex/topic-create-preserve-config has failed.
Run started by GitHub user iloveeyjafjalla (triggered by iloveeyjafjalla).

Head commit for run:
1e2779f64ccbcdbc7721ea3c71ef43d10af080be / iloveeyjafjalla <[email protected]>
fix(topic): keep an existing topic's broker settings when create is called again

A plain create writes the config built from the creation defaults, so calling 
it for a topic
that already exists on the broker resets every setting the request does not 
carry: the queue
counts go back to 8 and the permission back to RW. Reproduced against a real 
broker - a
6-queue topic answered a create whose form omitted the counts with 8 queues, 
and a write-only
topic (perm 2) came back read-write after a create that did not mention the 
permission. The
metadata table is written from the same values, so the console shows the reset 
as well.

The group path carried the same shape, fixed in #5930: read what the master 
already holds,
apply only the fields the request actually carries. Do the same for topics, and 
keep the
message type in the write protocol's add/alter form instead of echoing the 
broker's read map.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38869394346

With regards,
GitHub Actions via GitBox

Reply via email to