Yeti11H commented on issue #11304: URL: https://github.com/apache/rocketmq/issues/11304#issuecomment-6209222463
Hi maintainers, I investigated this issue on the current develop branch and found a related POP consumer lag problem in the asynchronous calculation path. When a pending POP request triggers `ConsumerLagCalculator.calculateLag()`, the calculation produces two results for a POP group: one for the normal topic and one for the retry topic. The current code passes `future::complete` as the recorder, so `CompletableFuture` keeps only the first result and silently drops the retry lag result. I prepared a focused fix that: - collects all results produced by the asynchronous calculation; - records both normal and retry lag after the future completes; - avoids recording metrics directly from the asynchronous callback thread; - keeps the existing public API and message semantics unchanged; - adds a regression test covering both result types and lag values. The related tests pass, including Checkstyle and SpotBugs validation. Would it be acceptable for me to open a pull request for this focused fix? If so, could you please assign the issue to me or confirm that I should proceed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
