Loyal-Young opened a new pull request, #6719:
URL: https://github.com/apache/rocketmq-dashboard/pull/6719

   ## What is the purpose of the change
   
   Fixes #6718. System Alerts export currently downloads a partial CSV and 
reports success when a later page is empty despite the API still reporting 
unseen alerts.
   
   ## Brief changelog
   
   - Reconcile the latest page total before interpreting an empty page.
   - Finish normally when the result set genuinely shrank to the rows already 
fetched.
   - Fail the export and skip the download when the empty page still reports 
missing rows.
   - Cover both outcomes in the page tests.
   
   This refines the empty-page progress guard from #2651 without restoring its 
old pagination loop.
   
   ## Verification
   
   - The new incomplete-page regression failed before the fix because no 
failure message appeared.
   - System Alerts page suite: 22/22 passed after the fix.
   - TypeScript `--noEmit`, changed-file ESLint (zero errors, one existing 
React Hooks warning), and `git diff --check` passed.
   
   ## AI assistance
   
   AI assistance helped compare the export loop with its existing shrink 
regression and draft the new test. I reviewed the completion condition and ran 
the checks above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to