chennaji9 opened a new pull request, #6661: URL: https://github.com/apache/rocketmq-dashboard/pull/6661
### Which Issue(s) This PR Fixes None — small self-contained fix found by inspection (no issue tracked). ### Brief Description `deploy/deploy.sh`'s `verify` fails the deployment when the backend health check never turns healthy, but the web branch only `warn`ed on a non-200 result and then printed the success banner unconditionally: a deployment whose web tier kept returning 503 (or where curl never connected) ended with `🎉 部署完成 → http://$REMOTE_HOST:$PUBLIC_PORT/` and exit status 0. - A web health check that is still not 200 after the retry loop now fails the run with `err`, matching the backend branch's semantics, before the success banner is printed. ### How Did You Test This Change? Replayed the extracted `verify` function with a fake `curl`/`sleep` on `PATH` (no network, no containers): | scenario | old | new | |---|---|---| | always 503 | exit 0, success banner printed | exit 1, no banner | | curl never connects (000) | exit 0, success banner printed | exit 1, no banner | | fails twice then 200 | exit 0 with banner | identical (exit 0, banner) | `bash -n` and shellcheck clean (the remaining findings in `deploy.sh` are pre-existing). ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits (`fix:`) - [x] Tests added or updated for non-trivial changes (behaviour verified by direct function replay above; the repo has no shell test harness) - [x] New UI text has both Chinese and English entries under `web/src/i18n/` (n/a — no UI change) - [x] Architecture constraints stay green (n/a — no Java change) - [x] New source files carry the ASF license header (n/a — no new source file) - [x] Documentation touched where behaviour changed (n/a — failure now stops the script, matching `set -e` intent and the backend check) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
