zjncs opened a new pull request, #6659:
URL: https://github.com/apache/rocketmq-dashboard/pull/6659
### Which Issue(s) This PR Fixes
Fixes #6658
### Brief Description
The Proxy 管理 tab's 连接数 column — and its CSV export — showed a value no code
path ever measured:
- the only real-cluster discovery path (`RocketMQClusterProvider`,
heartbeat-syncer based) builds every discovered `ProxyVO` with
`.connections(0)` hardcoded;
- `mapClusters` masked a missing value with `proxy.connections ?? 0`;
- only the demo repository invents numbers (156).
So production showed a "measured" 0 for every proxy and demo mode showed an
invented count — the same fabricated-value class as #769. This drops the
column, its CSV export and the `ProxyRecord.connections` field, mirroring the
earlier removal of the NameServer Connections column ("fabricate a hardcoded 0
for every nameserver").
Relationship to #5948 (open, same file): that PR removes the
proxy/nameServer *version* lines; this one removes the *connections* lines in
the same literals. The touched lines are disjoint, so both directions rebase
trivially.
Non-goals: `ProxyVO.connections` stays on the server (still returned by
`/api/proxies` and used by the demo data), and no attempt is made to count real
connections — no per-proxy source exists today (the heartbeat-syncer
connections are a different semantic).
### How Did You Test This Change?
- Red-green: the new test `does not render a Connections column for proxies`
failed on the unmodified tree @ `e2f815fb` (the column rendered with the mock's
invented 2340) and passes after the fix.
- `npx vitest run src/pages/studio/__tests__/BrokerCluster.test.tsx` —
**18/18 pass** (16 pre-existing + the fractional-disk test already on the
branch + 1 new).
- `npx eslint src/pages/studio/BrokerCluster.tsx
src/pages/studio/__tests__/BrokerCluster.test.tsx` — clean. `npx tsc --noEmit`
— clean.
AI assistance was used; the failure was reproduced before changing
production code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
