Yanghanrui666 commented on issue #6118:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/6118#issuecomment-6160163939

   **Design detail for review**
   
   Following up with the concrete shape so the design can be settled here:
   
   1. **Entry point** - a `Check all connectivity` button next to `Export` on 
Settings -> Data sources, disabled while the list is empty, so the action can 
never run against nothing.
   2. **Scope** - the rows currently matching the table's own search/type 
filter, de-duplicated by data source key. The drawer header states the exact 
scope (`search X, type Y`) so the operator can see what will be probed.
   3. **Concurrency** - a fixed pool of 3 in-flight probes. The batch calls the 
existing `POST /settings/datasources/test`, so there is no backend change and 
no long-running job.
   4. **Credentials** - `Basic Auth` / `Bearer Token` rows are not probed. They 
are reported as `Skipped` using the existing `settings.dataSourceAuthTestHint` 
text, and no request is sent.
   5. **Partial failure** - a rejected request is a row-level `Failed` result 
carrying the message the endpoint returned (or a translated generic fallback), 
never an aborted batch.
   6. **Result surface** - per-row name / type / URL / status / latency / 
instance count / message, a summary of total, succeeded, failed and skipped, an 
outcome filter, and CSV export of the visible rows.
   7. **Tests** - unit tests for the batching helpers (de-duplication, 
concurrency bound, skip, latency aggregation), plus a component test for the 
drawer and an entry-point test on the tab.
   
   If this shape is acceptable I can open the pull request right away, and I am 
happy to adjust any of the above first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to