zmuxuny opened a new pull request, #6369:
URL: https://github.com/apache/rocketmq-dashboard/pull/6369

   ### Which Issue(s) This PR Fixes
   
   Fixes #6355
   
   ### Brief Description
   
   A selected-message resend can finish after the operator changes the DLQ 
drawer page or page size. The completion currently reloads the captured old 
pagination and clears selections made while the request was pending.
   
   Keep the current drawer pagination in a ref and refresh that query on 
completion. Remove only the submitted message IDs from selection, preserving 
any newly selected messages. Existing drawer-close/unmount request ownership 
guards remain in place.
   
   ### How Did You Test This Change?
   
   Base: rocketmq-studio at 779b8c0e7aed2396d3cc72743dcd544ea48e9ae6.
   
   - Added two real DLQPage regressions using 40 fixed message IDs sliced by 
requested page/size. Both fail against unchanged production code (the 
completion requests page 1 / size 20).
   - `node node_modules/vitest/vitest.mjs run --maxWorkers=1 
src/pages/instance/__tests__/DLQPage.test.tsx 
src/services/messageService.test.ts src/api/dlq.test.ts`: 3 files, 53 tests 
passed.
   - Page change preserves message-21 selection; page-size change preserves 
message-2 while submitted message-1 remains visible and unselected. Existing 
close/unmount controls pass.
   - Changed-file ESLint: 0 errors, 1 existing react-refresh warning. Prettier, 
`tsc -b`, and `git diff --check` passed.
   - Full frontend lint and production build passed for this production fix 
(license check: 133 components / 140 files). The final fixture-only correction 
was rechecked with the related suite and TypeScript.
   - Tests use mocked services; no real broker or credentials. Full frontend 
suite and backend tests were not run locally. CI remains to be verified.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits
   - [x] Regression tests added, named with Test suffix
   - [x] No new UI text or source files
   - [ ] Backend architecture checks (not run locally; frontend-only change)
   - [x] No documentation change needed for restoring existing pagination 
behavior
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to