Loyal-Young opened a new pull request, #6468:
URL: https://github.com/apache/rocketmq-dashboard/pull/6468

   ### Which Issue(s) This PR Fixes
   
   Fixes #6465
   Refs #4708
   
   ### Brief Description
   
   Normalize whitespace, underscores and hyphens consistently with 
`MetricsBackendType` before checking the connection-test allowlist. In 
particular, `victoria_metrics` is accepted by the data-source save DTO but the 
connection test previously rejected it without making a probe.
   
   The explicit allowlist continues to reject unsupported types. This does not 
use the resolver's unknown-type fallback or change save validation. Recognized 
VictoriaMetrics aliases use its tenant-prefixed instant-query path.
   
   yyqdbngt previously identified this mismatch in #4708, which was closed by 
the stale workflow. The mismatch remains in the current base; this PR adds 
parameterized HTTP-probe coverage for it.
   
   ### How Did You Test This Change?
   
   - The underscore, padded uppercase underscore and hyphen variants failed 
against the original service. Canonical and space-separated spellings passed as 
controls.
   - `mvn -B -ntp 
-Dtest=SettingsServiceTest,DataSourceDTOTest,DataSourceTestDTOTest,MetricsBackendTypeTest
 test`: **58 passed**.
   - Tests assert the VictoriaMetrics query URL and retain the existing 
unsupported-type rejection test.
   - Maven Checkstyle and `git diff --check`: passed.
   
   HTTP is exercised through `MockRestServiceServer`; no real metrics server or 
full backend suite was run.
   
   ### Checklist
   
   - [x] One coherent fix with regression tests
   - [x] No new dependencies or UI strings
   
   ### AI Assistance
   
   AI assistance was used to compare the DTO, backend resolver and 
connection-test normalizers, draft the focused fix and parameterized 
regression, and run the listed checks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to