zmuxuny opened a new pull request, #6187:
URL: https://github.com/apache/rocketmq-dashboard/pull/6187

   ## Summary
   
   Fixes #6181.
   
   This continues @yyqdbngt's original finding, six-line fix, and collector 
regression in #4675, which was closed without merging. Credit for that original 
work belongs to @yyqdbngt. This contribution revalidates the fix on the current 
`rocketmq-studio` base and adds collector-to-processor lifecycle regressions.
   
   A successful consume-stats response can contain a known backlog but no 
consumption timestamp. The Apache business collector currently omits 
`consumer.delay.seconds` in that case. Successful-collection reconciliation 
interprets the missing series as a disappeared resource and incorrectly 
resolves an existing delay incident.
   
   - Emit an explicit `UNAVAILABLE` delay sample with the existing 
consumer-group and cluster identity and a `CONSUMER_TIMESTAMP_UNAVAILABLE` 
reason.
   - Preserve both `FIRING` and `ACKED` incidents while the timestamp is 
unknown.
   - Verify that a later real timestamp with a healthy delay resolves the 
incident normally.
   
   ## Validation
   
   - On unchanged production code: 39 focused tests, with exactly three 
expected regression failures (missing delay sample and incorrect resolution of 
FIRING/ACKED incidents).
   - After the fix: 71 focused tests passed across the collector, processor, 
scheduler, evaluator, state machine, and rule-test service suites.
   - Independent reviewer: 52 focused tests passed across four key suites.
   - Maven Checkstyle and `git diff --check` passed.
   
   The changed collector and tests were compiled against existing artifacts 
from the exact tested base, `5e4c39b053c35a5598cc79ff331b8a54e649d7b1`. This is 
focused verification, not a full clean build or full repository test run. All 
existing Apache license headers are retained. GitHub CI is pending.
   
   AI assistance was used for current-base validation and the added lifecycle 
regressions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to