The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/ai-second-stop-terminal-write has failed.
Run started by GitHub user lizhimins (triggered by lizhimins).

Head commit for run:
f5137c1d55d51ecf7eb735e91e3f298ca6146b59 / unbridled-41 
<[email protected]>
test(ai): stop racing the worker when asserting the stop attribution

AiRunServiceTest.stopShouldAbortALiveRunAndLeaveItStoppedWithUserStopTest
looked the run's handle up again after service.stop(RUN_ID) and required it
to be present with the user-stop reason. stop() cancels the worker, whose own
finalisation removes the registration (AiRunExecutor.execute's finally calls
registry.finish), so that lookup races with the removal: measured here, the
registration is gone 2 ms after the run reaches STOPPED. On a loaded runner
the worker wins and the assertion fails with

  Expecting Optional to contain a value but it was empty
  at AiRunServiceTest.java:327

which is what CI recorded on three unrelated branches (only one of which
touches this class), making roughly one in ten runs red for no reason.

Capture the handle before stopping and assert the reason on that reference -
the same intent, without the race. The user-visible attribution is still
asserted separately through the run row (status STOPPED, stopReason USER_STOP).

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37905137114

With regards,
GitHub Actions via GitBox

Reply via email to