tju-yxq opened a new pull request, #5154:
URL: https://github.com/apache/rocketmq-dashboard/pull/5154
### Which Issue(s) This PR Fixes
- Fixes #3556
### Brief Description
Re-submits the previously reviewed change (supersedes #4480, which was
auto-closed by the stale bot after 7 days without activity) rebased onto
current `master` at `0228dad5` — no conflicts. Alert rule counters now use
result-set-wide statistics (matching rows across all pages of the filtered
result set) instead of mixing page-local counts into the summary.
### How Did You Test This Change?
Run on the rebased branch (`7a623eb9`):
```
cd server && mvn -B -ntp
'-Dtest=AlertRuleControllerTest,AlertServiceTest,ClusterAlertRuleControllerTest,MybatisPlusAlertRepositoryTest'
test
AlertRuleControllerTest: 23, AlertServiceTest: 84,
ClusterAlertRuleControllerTest: 7, MybatisPlusAlertRepositoryTest: 17
Tests run: 131, Failures: 0, Errors: 0, Skipped: 0 — BUILD SUCCESS
cd web && npm test -- AlertsPage --run
Test Files 2 passed (2)
Tests 45 passed (45)
cd web && npm run lint
0 errors (11 pre-existing warnings in unrelated files)
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks)
- [x] New source files carry the ASF license header
- [ ] Documentation touched where behaviour changed (README / `docs/` /
in-app help)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
