pilichoumao commented on PR #4550: URL: https://github.com/apache/rocketmq-dashboard/pull/4550#issuecomment-5808475158
Rebased onto `rocketmq-studio@856b97fd` to stay conflict-free after this morning's merge wave. Interaction with the two client-domain PRs that landed: - **#4846 (Node.js language mapping)**: merged automatically — its `mapLanguage` addition and this PR's proxy-merge path are disjoint. Proxy rows still report only what the proxy actually returns; a Remoting Node.js client now correctly shows `NodeJS` on both paths. - **#4850 (unmapped-language charting)**: this PR's inline null-language rendering was superseded by #4850's canonical `renderLanguageTag`/`UNKNOWN_LANGUAGE` helpers, and the merged code adopts them. One integration point was adjusted: the language/version distribution bucket now maps this PR's nullable `version` (proxy rows) through the same `unknown` sentinel, so the chart never prints a literal `null`. The regression test was updated to the merged semantics (missing language renders the localized "unknown" label; protocol/version keep the `-` placeholder). Re-verification on the rebased commit: backend `clean test` — **3,215 tests, 0 Checkstyle violations**, with the only error being `ResourceOwnershipGuardTest#migrationConcurrentStartupIsIdempotentTest`, which reproduces identically on pristine `856b97fd` (trunk-side flake, unrelated). Frontend: `ClientsPage` + `clientConnectionDiagnostics` **28/28 passed**, `tsc -b && vite build` clean, Prettier clean. Note: #5007's new web `license:check` gate fails identically on pristine trunk in this environment (control build verified), so bundle verification stops at the successful `vite build`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
