Frun1na commented on PR #4732: URL: https://github.com/apache/rocketmq-dashboard/pull/4732#issuecomment-5768981622
Thanks for the thorough review — all four blocking items are now addressed in e60e99c5. **Item 1 — answer: we took option (a).** The Tencent path is now part of this PR: `TencentInstanceProvider.toSubscriptionEntry` routes `filterMode` through `SubscriptionFilterModes.fromExpressionType`, with a provider test pinning `SQL92` → `type=SQL92`, `filterMode=SQL`. The test fails on the base revision with `expected: "SQL" but was: "SQL92"`. The helper's javadoc now says "Apache, Aliyun and Tencent", and the description no longer claims "both providers have normalized" — it lists three producers and states all three are normalized here. The title was retitled accordingly (`fix(consumer): ...`). **Item 2 —** the §6.4 `type` row now documents `TAG` / `SQL92` / `CLASS_FILTER` as the raw expression type each producer passes through, replacing `NORMAL` / `FIFO` / `DELAY` / `TRANSACTION`. **Item 3 —** the `consistency` row now documents the Apache `consistent`/`null` domain plus the vendor-provided string forms (e.g. Aliyun's `true` / `false` from `String.valueOf`). **Item 4 —** `web/src/mock/consumers.ts` union types and all fixture rows were migrated to the API values (`TAG` / `SQL` / `CLASS_FILTER`, `consistent` / `inconsistent`), and the fixture `type` values follow the expression-type domain, so mock mode no longer degrades the tag colors. The same migration was applied to the subscription fixtures in `ConsumerPage.test.tsx`. `consumer.filterAll` was left unreferenced as suggested. Verification: the Tencent provider test (mutation-sensitive, red on base), ConsumerPage 37/37, consumerService 17/17, `tsc --noEmit` and eslint clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
