RockteMQ-AI commented on issue #4789:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/4789#issuecomment-5765164913

   ## Evaluation
   
   **Classification:** Bug — instance identity resolution ambiguity
   **Severity:** MEDIUM-HIGH
   **Status:** ✅ Confirmed
   
   ### Verification
   
   Code references verified against `rocketmq-studio @ 4c697f07`:
   
   - `InstanceRepository.findByIdentifier` (line 42-57): 
`findByName(identifier)` is tried before `findById(Long.parseLong(...))` — a 
numeric instance name shadows the numeric ID.
   - `InstanceService.loadCounts` (line 180-186): passes 
`String.valueOf(instance.getId())` to provider, which re-resolves through the 
ambiguous path.
   - `requireInstanceName` (line 554-562): no charset constraint — pure-digit 
names are accepted.
   - `ApacheInstanceProvider.countTopics` (line 76-81): maps through 
`findByIdentifier`, confirming the shadowing.
   
   ### Impact
   
   - Wrong resource counts on instance list when a name matches another 
instance's numeric ID.
   - Delete guard evaluates against the wrong instance — can orphan 
topics/groups or block legitimate deletion.
   
   ### Associated PR
   
   PR #4790 (by @unbridled-41) — fix: resolve resource counts by canonical 
instance name.
   
   ---
   *Evaluated by github-manager bot*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to