unbridled-41 commented on PR #4740:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4740#issuecomment-5758627319
### Evidence (recorded at the PR head)
1. **Head / diff self-check** — `fix/restore-draft-on-refused-send` @
`ed7f223f`, one commit; `git show --numstat` = `AiPage.test.tsx 34/0`,
`useAgentRun.test.ts 5/5`, `useAgentRun.ts 24/10`, `useAiSend.ts 9/6`,
`useDraftHandoff.ts 7/2`. The `useAgentRun.test.ts` edits are the five fixtures
that declared `send` as `Promise<void>` — caught by `npx tsc -b`, which vitest
does not run.
2. **Red on base** — with only the test file added on `7ce9a682`: `npx
vitest run src/pages/ai/__tests__/AiPage.test.tsx -t
"givesTheDraftBack|keepsTheHandoffDraft"` → `×
givesTheDraftBackWhenTheServerRefusesTheSendTest` (expected value `第二次发送`,
received `''`) and `× keepsTheHandoffDraftWhenTheSendIsRefusedTest` (expected
`检查集群状态`, received `''`).
3. **Teeth per fix** — the handoff case was re-run with only the
`useDraftHandoff` part of the fix reverted: it failed again, and passed once
restored (the composer case depends on the `useAgentRun`/`useAiSend` part
alone). So neither half is covered by the other.
4. **Green on branch** — `npx vitest run
src/pages/ai/__tests__/AiPage.test.tsx` → `17 passed (17)`; `npx vitest run
src/pages/ai src/api/ai` → `18 files, 253 passed (253)`.
5. **Full suite on branch** — `npx vitest run --maxWorkers=4` → `Test Files
134 passed (134)`, `Tests 1237 passed (1237)`. One earlier full run overlapped
another vitest process and hit the repository's known load-sensitive
`ConsumerPage > keeps the latest client stack when an older request resolves
last` case; the clean run above, with no competing load, is all green, and that
file is untouched by this change.
6. **Build / types / lint / CI** — `npx tsc -b` clean, `npx eslint <the 5
changed files>` clean, `npm run build` → `✓ built in 11.10s`. No workflow run
was created for this head SHA; CI fails to start for every PR in this
repository at the moment (`CI pull_request startup_failure`, e.g. 35576031888 @
2026-09-21T08:04:50Z), so the local results above are the evidence.
Duplicate check before submission: no open PR or issue covers draft
restoration after a refused send; the two open AI reports (#4614, #4632) are
about the run lifecycle, and the composer's own documented contract ("a
rejected send … should put the text back") is what this change restores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
