beautyarbutin opened a new pull request, #4773: URL: https://github.com/apache/rocketmq-dashboard/pull/4773
### Which Issue(s) This PR Fixes - Fixes #3150 ### Brief Description The consumer subscription-mode selector currently filters only the records returned for the active page. This change sends the selected mode to the page API and applies it before pagination for both Apache and cloud-backed providers. Switching modes resets the UI to page 1, and exports use the same mode normalization. This reimplements the still-open issue on the current `rocketmq-studio` branch. Related earlier attempts #3160 and #4053 were closed when that branch was removed during the previous branch migration; #4172 was closed as a duplicate. ### How Did You Test This Change? - `cd server && mvn -B -ntp "-Dtest=ConsumerGroupControllerTest,MetadataServiceTest,InstanceProviderTest,ApacheInstanceProviderTest,RocketMQMetadataProviderTest" test`: 129 tests passed. - `cd web && npm test -- --run src/pages/instance/__tests__/ConsumerPage.test.tsx src/api/consumerGroups.test.ts`: 41 tests passed. - `cd web && npx eslint src/api/consumerGroups.test.ts src/api/metadata.ts src/pages/instance/__tests__/ConsumerPage.test.tsx src/pages/instance/consumer.tsx`: passed. - `cd web && npx tsc -b --pretty false`: passed. - `cd web && npm run build`: passed. - `cd server && mvn -B -ntp test`: attempted; 3,054 tests ran with 0 failures, 18 errors, and 4 skipped. The errors are outside the changed paths and require unavailable local MySQL-backed contexts or the Claude Code CLI expectation in `ClaudeCodeAgentProviderTest`. ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / `refactor:` / `chore:` / `docs:` / `perf:`) - [x] Tests added or updated for non-trivial changes, test methods named `...Test` - [x] New UI text has both Chinese and English entries under `web/src/i18n/` (no new UI text) - [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit checks; the full suite is environment-blocked as noted above) - [x] New source files carry the ASF license header - [x] Documentation touched where behaviour changed (no documentation update required for this bug fix) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
