unbridled-41 commented on issue #1345: URL: https://github.com/apache/rocketmq-dashboard/issues/1345#issuecomment-5758846012
Status note: the preview-path error state this issue asked for was never implemented, and it is being worked on now. - Issue: #4731 traces the current behavior on the base commit (`7ce9a682`): `AlertRuleAssetList.handleView` catch leaves `viewContent` at `''` and the modal body branches on `viewLoading` alone, so a failed preview is an empty pane with no retry (the Grafana dashboard list has the same two paths). - PR: #4734 adds a `viewError` state to both components and renders an error with a retry inside the modal; two regression tests fail on the base commit and pass with the change. `npx vitest run --maxWorkers=4` → 134 files / 1237 tests, `npx tsc -b`, `eslint` and `npm run build` are clean on the branch. The request-ownership half of this issue is already in the code (`viewRequestId` in both components, pinned by the "keeps the latest preview when an earlier request resolves last" tests), so only the explicit error state was missing. It is implemented in #4734, which targets the development trunk `rocketmq-studio`. This issue is closed, so the pull request's `Fixes` keyword does not apply to it (GitHub also interprets closing keywords only for pull requests that target the repository default branch, and this one targets `rocketmq-studio`); it is referenced here so the earlier discussion is not lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
