btlqql commented on PR #4686:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4686#issuecomment-5762100065
Rebased onto `4c697f07` (clean) and the mechanical item is amended into the
same commit.
- The three test methods now end in `Test`, using the names you suggested:
`aFailedSessionRevokeMustNotReplaceTheStoredPasswordTest`,
`aSuccessfulPasswordChangeStillReplacesTheHashAndRevokesSessionsTest`,
`aWrongCurrentPasswordStillRejectsTheChangeAndKeepsTheStoredHashTest`.
- The file ends with a newline (`\ No newline at end of file` is gone).
- The third test stays: #4689 was closed rather than merged, so nothing else
covers the mismatched current password. Its javadoc now states that it pins the
stored row and not the response shape, which is
`AuthPasswordChangeStatusIntegrationTest`'s job — so the class stays about
atomicity.
Re-ran the mutation check on the rebased tree to be sure the rename did not
dent it — annotation removed from `changePassword`, tests kept:
```
[ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0
[ERROR]
AuthServicePasswordChangeIntegrationTest.aFailedSessionRevokeMustNotReplaceTheStoredPasswordTest
-- Time elapsed: 1.193 s <<< FAILURE!
Expecting value to be false but was true
at
...aFailedSessionRevokeMustNotReplaceTheStoredPasswordTest(AuthServicePasswordChangeIntegrationTest.java:95)
```
Whole suite on a host with MySQL 8 reachable: 3148 tests, 0 failures, 0
errors (3145 on the untouched head).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
