Frun1na opened a new issue, #4768:
URL: https://github.com/apache/rocketmq-dashboard/issues/4768

   ### Which Documentation
   
   `docs/ai-agent-architecture.md` — two claims that contradict the 
implementation.
   
   ### What Is Wrong
   
   1. **Tool-output truncation scope (§"一个解析器,两种输出").** The 32 KiB ceiling is 
listed under
      "两侧内容**故意不同**" as "工具输出在落库侧截到 32 KiB 并保留 `outputBytes`/`truncated`" — 
implying
      the live SSE stream carries the full output and only the persisted copy 
is cut. The opposite is
      true: `AgentEventProjector` applies the ceiling to both sides (its 
javadoc: "Ceiling for a tool
      output **on both sides**"), and the same `SanitisedOutput` feeds 
`LiveEvent.ToolDone` and
      `TimelineEvent.ToolResult`. A reader integrating against the live stream 
would not expect
      truncation there.
   2. **Checkstyle rule scope.** The note says `style/rmq_checkstyle.xml` 
rejects non-ASCII characters in
      Java sources. The `RegexpSingleline` rule only matches CJK code points 
and fullwidth punctuation
      (its message is literally "Not allow chinese character !"); 
Latin-extended characters would pass.
   
   ### Suggested Change
   
   1. Move the truncation statement out of the "deliberately different" list 
and state that both sides
      are cut at 32 KiB.
   2. Describe the rule as rejecting Chinese characters (CJK ranges and 
fullwidth punctuation).
   
   Opened PR #4767 for this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to