Frun1na opened a new issue, #4733:
URL: https://github.com/apache/rocketmq-dashboard/issues/4733

   ### Before Creating the Bug Report
   
   - [x] I have searched the [open 
issues](https://github.com/apache/rocketmq-dashboard/issues) and found no 
similar issue.
   
   ### What Happened
   
   On the Consumer Group page, the 订阅模式 (filter mode) column of the 
subscription tables shows the
   raw API codes `TAG` / `SQL` / `CLASS_FILTER` instead of the labels the UI 
used to display, and every
   row loses its color coding (all fall back to the default gray tag).
   
   The column matches `filterMode` against the strings the API returned before 
#3349
   (`全量` / `Tag 过滤` / `SQL92 过滤`):
   
   ```tsx
   const colorMap: Record<string, string> = {
     全量: 'default',
     'Tag 过滤': 'blue',
     'SQL92 过滤': 'purple',
   };
   return <Tag color={colorMap[mode] || 'default'}>{mode}</Tag>;
   ```
   
   Since #3349 both providers normalize the broker expression types through
   `SubscriptionFilterModes.fromExpressionType`, which returns `TAG` / `SQL` / 
`CLASS_FILTER`, so the
   lookup never matches any more.
   
   ### Expected Behavior
   
   The column should render the localized labels — `Tag 过滤` (blue), `SQL92 过滤` 
(purple) and a label
   for `CLASS_FILTER` — which is what the already-existing but unreferenced 
i18n keys
   `consumer.filterTag` / `consumer.filterSql92` provide.
   
   ### Steps to Reproduce
   
   1. Open an instance's Consumer Group page and expand a group's subscription 
details (or open the
      group detail modal).
   2. Look at the 订阅模式 column: values render as `TAG` / `SQL` / `CLASS_FILTER`, 
all gray.
   3. `ConsumerPage.test.tsx` did not catch this because its mocks fed the old 
display strings
      (`filterMode: 'Tag 过滤'`) instead of the values the API returns.
   
   ### Environment
   
   - RocketMQ Studio `rocketmq-studio` @ `7ce9a682`
   - Backend: `SubscriptionFilterModes.fromExpressionType` (both Apache and 
Aliyun providers)
   - Frontend: `web/src/pages/instance/consumer.tsx` subscription columns
   
   ### Are You Willing to Submit a Pull Request?
   
   Yes — #4732 fixes this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to