unbridled-41 commented on PR #4750:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4750#issuecomment-5759476290
### Evidence for this PR
**Head / diff (verified against the pushed branch)**
- head `49c4ee1c1b841623c98ab1fc580be028551708fa`, base `rocketmq-studio`
(tip `cd448e17`), 1 commit, `mergeStateStatus: CLEAN`.
- `git show --stat 49c4ee1c` → `RocketMQMetadataProvider.java +7/-0`,
`RocketMQMetadataProviderTest.java +36/-0`.
**Red → green**
```
$ cd server && mvn -B -ntp -o test -Dtest=RocketMQMetadataProviderTest
[ERROR] ...listConsumerGroupsShouldGradeAMissingRetryTopicRouteAsOfflineTest
<<< FAILURE!
but was: -1
[ERROR] Tests run: 45, Failures: 1, Errors: 0, Skipped: 0 # BUILD
FAILURE
$ mvn -B -ntp -o test
-Dtest=RocketMQMetadataProviderTest,RocketMQAdminClientImplTest,ProxyConsumerResolverTest
[INFO] Tests run: 45, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 69, Failures: 0, Errors: 0, Skipped: 0
[INFO] Tests run: 120, Failures: 0, Errors: 0, Skipped: 0 # BUILD
SUCCESS
```
**The two states stay distinguishable**
The new test asserts `onlineInstances == 0` for
`MQClientException(TOPIC_NOT_EXIST, "… %RETRY%…")`, while the pre-existing
`listConsumerGroupsShouldMarkOnlineInstancesUnknownWhenConnectionLookupFailsTest`
(an `IllegalStateException` from the admin call) still asserts `-1` and still
passes — so a genuine unavailable inventory is still reported as unavailable,
and only the graded "no live data" case changed.
**Why the other two call sites are consistent**
`isGroupNotOnline` is also used by `getGroupProgress`
(`RocketMQMetadataProvider.java:666`) and `getGroupSubscriptions` (`:699`).
Both already document that a group with no live data is a business state, not a
connectivity failure: the progress read now returns an empty list instead of a
502 for a group whose retry topic is not routable yet, and the subscription
read tries the proxy resolver before returning an empty list — the same outcome
the other graded codes produce there.
**Duplicate check (re-run against the current indexes)**
- Open PRs (205 titles) / open issues (214 titles), keywords
`onlineInstances`, `consumer connection`, `retry topic`, `TOPIC_NOT_EXIST`,
`unknown online`: only #4006 (`RocketMQClientProvider` 502 when every group is
offline, different endpoint) and #4463 (producer scans).
- `git log --oneline -400 origin/rocketmq-studio | grep -i
"group\|consumer"` → #4544 (`cd448e17`) introduced the three-state resolution
but not this grading; no other commit touches `isGroupNotOnline`.
**Scoring**
PRIORITY = 69 (impact 22 + blast radius 14 + reproducibility 18 +
maintenance value 15); FIX_CONFIDENCE = 92.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
