Aias00 commented on PR #4508: URL: https://github.com/apache/rocketmq-dashboard/pull/4508#issuecomment-5759833594
Addressed the requested topology distinction in `0ddd83a0f` after rebasing onto `rocketmq-studio@cd448e17f`: 1. `require` now canonicalizes the NameServer address set and Broker address set for every same-name match. Multiple Studio instances with identical physical identity collapse to the deterministic first instance; only distinct physical identities return 409. 2. Added a regression where two instances expose `DefaultCluster` through the same two NameServers in different order and the same Broker set. It resolves to `instance-a` instead of returning 409. 3. `collectAll` now logs a warning when a cluster name maps to distinct physical topologies, including the sorted instance identifiers. 4. The 409 text now explicitly says the ambiguity is across physical clusters. The current seven platform tools still publish `clusterName`, so this PR keeps the resolver hardening as a compatibility safeguard. Moving those tools to required `instanceId` is the long-term direction, but it is a separate schema migration rather than part of this bug fix. Verification: focused resolver/tool tests 27/27; full backend suite 3077 passed with 3 skipped; Maven package passed; Checkstyle 0 violations; `git diff --check` passed; independent review found 0 issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
