Aias00 commented on PR #4527: URL: https://github.com/apache/rocketmq-dashboard/pull/4527#issuecomment-5759705557
Addressed the requested consolidation in `6540ada4`: 1. Rebased onto `rocketmq-studio@7ce9a682` and moved this PR base to `rocketmq-studio`. 2. Folded the ACL page from #4511 and alert-rule page from #4518 into this PR. 3. Replaced all three microtask wrappers with synchronous loading transitions and targeted rationale comments. 4. Standardized the three pages on keeping previous content mounted behind an Ant Design loading mask while stale-data actions are disabled. System Alerts now preserves the feed and scroll position instead of swapping it for a skeleton. 5. Added explicit ACL loading guards for rule edit/delete plus user credential reveal/copy, admin toggle, edit, and delete after independent review found the table mask alone was insufficient. Verification: focused tests 70/70, full frontend suite 1239/1239, production build passed, lint reported 0 errors and 11 existing warnings, Prettier and `git diff --check` passed. Independent re-review found no remaining issues. #4511 and #4518 are superseded by this combined change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
