beautyarbutin opened a new pull request, #11194: URL: https://github.com/apache/rocketmq/pull/11194
### Which Issue(s) This PR Fixes - Fixes #10833 ### Brief Description Metrics labels and OTLP gRPC headers were split on every colon in Broker, Proxy, and Controller. Values such as `https://collector:4317` or authorization header values containing colons therefore produced more than two parts and were discarded as invalid. This change limits each split to the first colon, preserving the complete value while keeping the existing invalid-entry handling. It also adds regression coverage for Broker, Proxy, and Controller, including the Controller and Proxy coverage requested on the earlier closed PR #10843. ### How Did You Test This Change? - Verified the new Broker, Proxy, and Controller regression tests fail on the previous implementation with an expected full URL but an actual `null` label. - Ran `mvn -B -ntp -pl broker,controller,proxy -DskipITs -Dtest=BrokerMetricsManagerTest#testMetricsLabelValueContainingColon,ControllerMetricsManagerTest,ProxyMetricsManagerTest -Dsurefire.failIfNoSpecifiedTests=false test`. - Ran the complete `BrokerMetricsManagerTest` test class: 30 tests passed with no failures or errors. - Checkstyle and SpotBugs passed for all three changed modules during the targeted build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
