123123213weqw commented on PR #4470: URL: https://github.com/apache/rocketmq-dashboard/pull/4470#issuecomment-5757306163
All three points are in — thanks for the precise review, and for naming the neighbouring handlers that already do this; it made the shape obvious. - **Test naming (the blocker).** Renamed to `malformedPropertiesFailDuringPreviewAndExecutionTest`. You are right that the checklist box did not match the diff — it does now. - **`parseProperties(input.properties());`** carries a one-line comment saying the call is validation-only and the parsed value is rebuilt in `execute`, so nobody deletes it as dead code. - **The assertion** imports `org.apache.rocketmq.studio.ops.ai.tool.core.ToolExecutionException` rather than spelling it out inline. ``` $ cd server && mvn -B -ntp test -Dtest=MessageSendToolHandlerTest [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0 [INFO] BUILD SUCCESS ``` On the issue: I have no preference — I can open a short one if you want the trail, or leave it as is. Your call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
