beautyarbutin opened a new pull request, #11185:
URL: https://github.com/apache/rocketmq/pull/11185

   ### Which Issue(s) This PR Fixes
   
   - Fixes #10859
   
   ### Brief Description
   
   `IndexStoreService.putKey` returned `SUCCESS` after all three index write 
attempts failed. This change retains the result of each attempt and returns the 
final failure once retries are exhausted, while preserving the existing success 
path and `FILE_FULL` file rotation behavior.
   
   The regression test exercises `FILE_FULL`, `FILE_FULL`, and `UNKNOWN_ERROR`, 
then verifies that the final error is propagated after three attempts and that 
file rotation occurs only for the two `FILE_FULL` results.
   
   ### How Did You Test This Change?
   
   - Confirmed the new regression test failed before the production change: 
expected `UNKNOWN_ERROR` but received `SUCCESS`.
   - Ran `mvn -pl tieredstore -am -DskipITs -Dtest=IndexStoreServiceTest 
-Dsurefire.failIfNoSpecifiedTests=false test`.
   - Result: 11 tests passed; Checkstyle reported 0 violations; SpotBugs 
reported no errors or warnings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to