unbridled-41 commented on PR #4658:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4658#issuecomment-5754722745
## Verification evidence (updated after the second commit `99c5c5a8`)
The audit of this PR found the first regression modeled the wrong scenario
(a page-2 with a single row, where master's step-back happens to look
reasonable) and missed the opposite gap the refresh-only fix introduced (a
genuinely emptied page kept rendering empty). Both are corrected in commit
`99c5c5a8` — no history rewrite, one additional commit.
- **CI**: run `35555131480` ("CI", event `pull_request`) at head `99c5c5a8`
— conclusion `startup_failure` (the workflow never starts; repository-level
issue, other open PRs from the same window show the same). `check-runs`: 0. All
results below are from local runs of the exact head commit.
- **Red** (on unmodified master source, both regressions): `stays on the
page...` fails with `Unable to find an element with the text: Second page rule
5` — master stepped back to page 1 and rendered page-one rows after the
full-page delete. The emptifying regression pins the clamped re-query that only
exists in this fix.
- **Module**: `npx vitest run src/pages/ops/__tests__/AlertsPage.test.tsx` →
`Tests 28 passed (28)` (26 pre-existing + 2 new).
- **Full web suite** (this branch, head `99c5c5a8`): `npx vitest run
--maxWorkers=4` → `Test Files 122 passed (122)`, `Tests 1036 passed (1036)`,
zero failures. Pristine master baseline on this machine: 1034 passing; 1036 =
baseline + 2 new tests.
- **Build**: `npm run build` → `✓ built in 11.47s` (exit 0). Type check `npx
tsc --noEmit` → clean. `npx eslint` on the two changed files → 0 errors, 5
warnings (verified pre-existing on the master versions of these files).
- **Diff self-check** (`git diff --numstat
origin/master..fix/alerts-bulk-delete-page`): `106/0
web/src/pages/ops/__tests__/AlertsPage.test.tsx`, `15/2
web/src/pages/ops/alerts.tsx` — 2 files, no unrelated changes. Two commits:
`980eb5dc` (+40/0 test, +4/−2 source), `99c5c5a8` (+70/−4 test, +11/0 source).
### Disclosure
The first pushed commit's regression used a 21-rule fixture and asserted a
page-2 refresh that master also (accidentally) satisfied via its step-back when
the mocked refresh returned rows; the audit caught this, and commit `99c5c5a8`
replaces it with a state-aware mock and a genuinely full 20-row page plus the
empty-page clamp. The red/green evidence above is from the final code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
