Frun1na opened a new issue, #4648:
URL: https://github.com/apache/rocketmq-dashboard/issues/4648

   ### Environment
   
   * rocketmq-dashboard branch: rocketmq-studio (commit 5b761df8)
   
   ### What happened
   
   `studio.alerting.snapshot-retention` is documented (by its default `PT24H`) 
as an ISO-8601
   duration, but `CollectorScheduler.cleanUpSnapshots()` parses it with an 
unguarded
   `Duration.parse` on every hourly scheduled run. Any non-ISO value — for 
example the very
   natural `24h` — throws `DateTimeParseException` every run, the scheduled 
method never
   succeeds, and metric snapshots are never cleaned up: the table grows without 
bound with no
   error surfaced beyond a swallowed scheduler exception.
   
   ### What should happen
   
   A malformed retention value should be logged (with the offending value) and 
the cleanup run
   skipped, or the value validated at startup so the operator sees the 
misconfiguration
   immediately. Silently dying every hour makes the retention setting look 
functional while
   snapshot data accumulates.
   
   ### Additional context
   
   PR with fix and tests: #4647
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to