X-LightYear opened a new pull request, #4551: URL: https://github.com/apache/rocketmq-dashboard/pull/4551
## Summary - preserve `clusterId` through paginated Topic queries - preserve `clusterId` through paginated Consumer Group queries - add regression coverage for cross-cluster pagination isolation ## Root cause The paginated instance-provider contract dropped `clusterId` between `MetadataService` and `ApacheInstanceProvider`. As a result, the underlying metadata provider received `null` for the cluster filter and returned resources from all clusters under the same instance. ## Fix Add cluster-aware pagination overloads to the instance-provider contract and propagate the requested `clusterId` into the Apache metadata provider for both Topic and Consumer Group queries. Existing instance-wide behavior is preserved when no cluster is specified. The existing Aliyun and Tencent provider behavior is unchanged through the default interface implementation. ## Testing Passed: - `MetadataServiceTest`: 54 tests - `ApacheInstanceProviderTest`: 11 tests - `RocketMQMetadataProviderTest`: 43 tests - `InstanceProviderTest`: 1 test - `mvn -DskipTests package` - Checkstyle: 0 violations A full `mvn test` was also attempted locally. Unrelated environment-dependent tests failed because the Windows environment does not provide `sh` and the local MySQL test connection was unavailable. The tests covering this change all pass. Fixes #4549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
