RockteMQ-AI commented on issue #4509: URL: https://github.com/apache/rocketmq-dashboard/issues/4509#issuecomment-5714825514
**Issue Evaluation** Category: `bug` | Status: **Confirmed** Verified against `acl.tsx`. The `useEffect` (line ~188) calls `listAclRules` and `pageAclUsers`, setting `rulesLoading=false` and `usersLoading=false` in `.finally()`. However, neither loading flag is reset to `true` when filter/page/refresh dependencies change. The initial state (`useState(hasSelectedInstance)`) only covers the first render. **Root Cause:** Same pattern as #4526 — missing `setRulesLoading(true)` / `setUsersLoading(true)` at the start of the request effect when dependencies change. The `mounted` guard prevents stale responses from publishing, but there is no loading boundary for the new request. **Impact:** Stale ACL rows remain actionable (edit/delete buttons visible) while replacement data is loading. Operators may modify or delete rules that are no longer in the active filter result. **Severity:** medium — misleading UI state, potential for unintended mutations on stale data. An automated fix proposal will be generated. Reply `/approve` to proceed with PR generation. --- *Automated evaluation by github-manager-bot* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
