RockteMQ-AI commented on issue #4502: URL: https://github.com/apache/rocketmq-dashboard/issues/4502#issuecomment-5712555225
**Issue Evaluation** Category: `enhancement` | Status: **Evaluated** Verified against current `master` (987b748e). The analysis is accurate: - `ClientController` accepts `namesrvAddr` as a `@RequestParam` without any validation. - `ClientService.listConnectionsAt()` passes the raw address directly to `clientProvider.findConnectionsAt()`. - `MqAdminExtFactory.execute()` accepts any `namesrvAddr` and creates connections to it. - The `BrokerController` already has a `ClusterScope` / `NameServerRegistry` pattern that can be reused. **Feasibility:** Feasible — the proposed design reuses existing infrastructure. **Scope:** `ClientController`, `ClientService`, `MqAdminExtFactory`, and the `ClusterScope` resolution path. **Compatibility:** No breaking changes — the default behavior of restricting to registered NameServer endpoints is the correct security posture. The opt-out escape hatch preserves flexibility for advanced users. This is a valuable security hardening improvement. The proposed design is well-scoped and backward-compatible. --- *Automated evaluation by github-manager* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
