RockteMQ-AI commented on issue #4497:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/4497#issuecomment-5711876374

   **Issue Evaluation**
   
   Category: `enhancement` | Status: **Evaluated**
   
   **1. Type:** `enhancement`
   
   **2. Verification against codebase**
   - The Settings tab is explicitly disabled for cloud instances: 
`web/src/pages/instance/consumer.tsx:2089` — `disabled: isCloudInstance` where 
`isCloudInstance` is true for `ALIYUN` / `TENCENT`.
   - Backend settings endpoints are gated to Apache only: 
`server/src/main/java/.../instance/topic/MetadataService.java:489-501` calls 
`requireApacheInstance`, which throws HTTP 501 for cloud vendors.
   - `InstanceCapability` currently has no `CONSUMER_GROUP_SETTINGS` capability 
(`server/.../provider/InstanceCapability.java`), and neither 
`AliyunInstanceProvider` nor `TencentInstanceProvider` implements get/update 
consumer-group settings.
   - The reporter’s claims match the code: the capability and provider plumbing 
are missing, but the underlying SDK classes 
(`GetConsumerGroup`/`UpdateConsumerGroup`, 
`DescribeConsumerGroup`/`ModifyConsumerGroup`) are available.
   
   **3. Severity:** `medium`  
   It’s a UX/feature-parity gap for cloud instances, not a crash, data loss, or 
security issue. A workaround exists via the cloud provider’s own console/API.
   
   **4. Suggested action**
   - Mark the issue as an accepted enhancement and invite the reporter to open 
the PR.
   - Focus review on: the new `CONSUMER_GROUP_SETTINGS` capability contract, 
provider-specific `editableFields`, preserving immutable Aliyun fields 
(`deliveryOrderType`, retry-policy type), read-before-write for Tencent, and 
the existing `executeWithAudit` path for cloud mutations.
   - The reported test/build checks (229 passing backend tests, Checkstyle, 
ESLint, Prettier, production build) suggest the prototype is in good shape to 
review.
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to