f1amingo commented on PR #1379:
URL:
https://github.com/apache/rocketmq-clients/pull/1379#issuecomment-5709962079
Minor public-API nit before this ships as an npm package:
`src/consumer/index.ts` exports `LiteSimpleConsumerImpl`, which leaks its
host-only methods (`getRpcClientManager`, `getLogger`, `getRequestTimeout`,
`getSyncEndpoints`) into the published `.d.ts` — hard to change once released.
Suggest exporting only the interface + builder:
```ts
export * from './LiteSimpleConsumer';
// export { LiteSimpleConsumerImpl } from './LiteSimpleConsumerImpl'; //
drop this
```
Users only get instances via `build()` (returns the interface), matching how
`SimpleConsumerImpl` is kept unexported. Tests import the impl by file path, so
they're unaffected. (`LitePushConsumerImpl` is already exported — leave it,
that's separate.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
