unbridled-41 commented on PR #3151: URL: https://github.com/apache/rocketmq-dashboard/pull/3151#issuecomment-5697008246
@lizhimins Thanks — reworked along exactly those lines; head is now 2404fa6d. - `resolveRegistryTargetInstanceId` and all endpoint-text inference are deleted; zero or multiple endpoint matches are no longer treated as errors anywhere. - Preview, update, Broker config diff, and NameServer config diff now send only the cluster id and omit `instanceId`, so the target is resolved server-side by the existing authoritative paths (`ClusterService.resolveCluster(id)`, `BrokerConfigDiffService.compare(id, null)`, `NameServerConfigDiffService.compare(clusterId)` — all already accept `instanceId=null`; no backend change was needed). - Branch history cleaned: the merge commit and the workspace-notes commit are gone; the branch is a single commit on the current `rocketmq-studio`. - Regressions: a row whose endpoint shares no text with any instance endpoint still previews/updates (bodies carry no `instanceId`); two instances sharing the row's NameServer no longer get rejected — the request goes out; and both diff actions are asserted to be called with exactly the cluster id. All three were red on the unfixed source and on the previous draft. `src/pages/cluster` + `src/i18n`: 73 tests pass; `tsc`, `eslint`, `vite build` clean. The stale-response guards are untouched. Happy to re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
