89799969 opened a new pull request, #4474:
URL: https://github.com/apache/rocketmq-dashboard/pull/4474

   ### Which Issue(s) This PR Fixes
   
   - Fixes #4252
   
   ### Brief Description
   
   Cancelling the create Studio user dialog only called `setCreateOpen(false)`. 
The password dialog already resets on cancel; the create dialog did not. After 
typing a password and enabling admin and then cancelling, the next open still 
showed those values 鈥?a residual-secret / residual-privilege risk if the 
operator confirms by mistake.
   
   - `openCreateUserModal`: `createForm.resetFields()` before opening
   - Modal `onCancel`: close and `createForm.resetFields()`
   
   Previously submitted as #4351 against the removed `rocketmq-studio` branch 
(bulk-closed during the master migration). Replayed on the current `master` 
baseline; the same issue is still open and no open PR claims #4252.
   
   ### How Did You Test This Change?
   
   ```
   cd web && npm test -- --run 
src/pages/studio/__tests__/UserManagement.test.tsx
   ```
   
   11 tests, 0 failures (includes the new `clears the create-user form after 
the dialog is dismissed` case: open 鈫?type username/password/admin 鈫?cancel 
鈫?reopen 鈫?assert empty and admin unchecked).
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`fix:`)
   - [x] Tests added or updated for non-trivial changes, test methods named 
`...Test`
   - [x] No new UI text
   - [x] Focused frontend tests pass
   - [x] No new source files
   - [x] No documentation change is needed for this dialog reset correction
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to